Forces inventory build tests on CI and fixes a bug with CDA inventory #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that some instruments nodes names are empty so just skip them and just directly add datasets nodes into parent node. Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
Codecov ReportBase: 78.65% // Head: 84.67% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 78.65% 84.67% +6.01%
==========================================
Files 44 44
Lines 2516 2518 +2
Branches 373 374 +1
==========================================
+ Hits 1979 2132 +153
+ Misses 423 261 -162
- Partials 114 125 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that some instruments nodes names are empty so just skip them and just directly add datasets nodes into parent node.
It might not be enough to cover all cases, a more systematic analysis might be required to spot all "broken nodes".