Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable merge fix #55

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Variable merge fix #55

merged 1 commit into from
Oct 7, 2022

Conversation

jeandet
Copy link
Member

@jeandet jeandet commented Oct 7, 2022

No description provided.

@jeandet jeandet added the bug Something isn't working label Oct 7, 2022
Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 84.61% // Head: 85.69% // Increases project coverage by +1.07% 🎉

Coverage data is based on head (4aa736f) compared to base (04d04ed).
Patch coverage: 25.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   84.61%   85.69%   +1.07%     
==========================================
  Files          44       44              
  Lines        2555     2558       +3     
  Branches      386      388       +2     
==========================================
+ Hits         2162     2192      +30     
+ Misses        268      243      -25     
+ Partials      125      123       -2     
Flag Coverage Δ
unittests 84.94% <25.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
speasy/products/variable.py 77.57% <25.00%> (-1.44%) ⬇️
speasy/webservices/amda/ws.py 85.61% <0.00%> (+0.68%) ⬆️
speasy/webservices/amda/rest_client.py 84.15% <0.00%> (+2.97%) ⬆️
speasy/webservices/ssc/__init__.py 91.13% <0.00%> (+10.12%) ⬆️
speasy/webservices/amda/_impl.py 85.04% <0.00%> (+10.28%) ⬆️
...asy/webservices/cda/_inventory_builder/__init__.py 94.44% <0.00%> (+12.96%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jeandet jeandet merged commit e6f0538 into SciQLop:main Oct 7, 2022
@jeandet jeandet added this to the 1.0.2 milestone Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant