Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpc-hc-fork: Update to version 2.3.2.1 #13560

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

kborowinski
Copy link
Contributor

Updates the MPC-HC to latest version (v2.3.2)

@aliesbelik
Copy link
Collaborator

Looks like automatic update failed since versions for 64bit/32bit packages in the same 2.3.2 release are different:

MPC-HC.2.3.2.1.x64.zip vs MPC-HC.2.3.2.x86.zip.

 mpc-hc-fork: 2.3.2.1 (scoop version is 2.3.1) autoupdate available
Autoupdating mpc-hc-fork
Downloading MPC-HC.2.3.2.1.x86.zip to compute hashes!
VERBOSE: GET https://api.github.com/repos/clsid2/mpc-hc with 0-byte payload
VERBOSE: received 15217-byte response of content type application/json; charset=utf-8
The remote server returned an error: (404) Not Found.
URL https://github.com/clsid2/mpc-hc/releases/download/2.3.2/MPC-HC.2.3.2.1.x86.zip is not valid
ERROR Could not update mpc-hc-fork, hash for MPC-HC.2.3.2.1.x86.zip failed!

@aliesbelik aliesbelik changed the title Update mpc-hc-fork.json to v2.3.2 mpc-hc-fork: Update to version 2.3.2 Jul 3, 2024
@kborowinski
Copy link
Contributor Author

@aliesbelik Yes, you're right. Let's close this PR and wait for the next release to see if that is a new naming scheme for the packages, or if it was just a one-off change.

@aliesbelik aliesbelik changed the title mpc-hc-fork: Update to version 2.3.2 mpc-hc-fork: Update to version 2.3.2.1 Jul 3, 2024
@aliesbelik
Copy link
Collaborator

/verify

Copy link
Contributor

github-actions bot commented Jul 3, 2024

Your changes do not pass checks.

mpc-hc-fork

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@aliesbelik
Copy link
Collaborator

@kborowinski PR is ok, my only point was that the url for x64 version requires correction (looks like binaries for 64bit version were re-uploaded after release with changed revision) and autoupdate/check scripts cannot handle it properly.

@aliesbelik aliesbelik merged commit 17337d2 into ScoopInstaller:master Jul 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants