Enabled applications which require elevated privileges. #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. @lukesampson . Can you take a look at it? |
excitoon
force-pushed
the
shim-applications-which-require-elevated-privileges
branch
from
ba7666a
to
1b7ae6f
Compare
|
Rebased. |
|
Quick to make this work, execute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
Sometimes shim does not work because
CreateProcess()returnsERROR_ELEVATION_REQUIREDerror (e.g.,scoop install rufus && rufus). We can't completely replace code withShellExecute()because it would break running programs in the same console window, that is why I first check forERROR_ELEVATION_REQUIRED, and then useShellExecute()(in .NET way).I guess, this really fixes #1319 (#579) for UAC-enabled systems.