Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supporting: Update Newtonsoft.Json to 11.0.2, Newtonsoft.Json.Schema to 3.0.10 #3043

Merged
merged 1 commit into from
Feb 16, 2019

Conversation

niheaven
Copy link
Member

  • Update supporting\validator\bin\Newtonsoft.Json to 11.0.2
    • HIGHLIGHT: support for regex operator in JSON Paths
    • Latest Newtonsoft.Json version is 12.0.1, which has some compatibility issues with Json.Schema 3.0.10 and PowerShell Core 6.1.12 (On my PC)
  • Update supporting\validator\bin\Newtonsoft.Json.Schema to 3.0.10
  • Use .NET 4.5 instead of .NET 4.0, since Scoop's requirements is .NET Framework 4.5+
  • Modify json_path() to escape $version substitutions when $jsonpath has regex

EXAMPLE OF JPATH REGEX

"checkver": {
    "url": "https://dist.nuget.org/index.json",
    "jp": "$..versions[?(@.displayName =~ /.*recommended.*/)].version"
}

BTW, should supporting\shimexe\shim.csproj and supporting\validator\validator.csproj be deleted? build.ps1 is enough...

@niheaven
Copy link
Member Author

niheaven commented Feb 3, 2019

@r15ch13 Should this be merged or be closed and wait for your updating? Current ones are outdated for two years…

@rasa rasa requested a review from r15ch13 February 8, 2019 04:41
@r15ch13 r15ch13 merged commit 03ebcc2 into ScoopInstaller:master Feb 16, 2019
@niheaven niheaven deleted the update-supporting branch February 17, 2019 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants