Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manifest): xpath support in checkver and autoupdate #3458

Merged
merged 5 commits into from
May 13, 2019
Merged

feat(manifest): xpath support in checkver and autoupdate #3458

merged 5 commits into from
May 13, 2019

Conversation

chawyehsu
Copy link
Member

@chawyehsu chawyehsu commented May 13, 2019 •
edited
Loading

Close #3451

TODO list:

  • xpath in checkver
  • xpath in autoupdate hash extraction
  • xpath in json schema

to be supplemented

@chawyehsu chawyehsu changed the title feat(manifest): support xpath in checkver and autoupdate feat(manifest): xpath support in checkver and autoupdate May 13, 2019
@chawyehsu chawyehsu marked this pull request as ready for review May 13, 2019 08:46
Ash258
Ash258 approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@Ash258 Ash258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r15ch13 r15ch13 merged commit f606285 into ScoopInstaller:develop May 13, 2019
@chawyehsu chawyehsu deleted the patch-17 branch May 14, 2019 02:50
@Ash258 Ash258 mentioned this pull request May 14, 2019
Merged
1 task
@Ash258
Copy link
Contributor

Ash258 commented May 15, 2019

@h404bi Found one problematic xml file

According to multiple xpath testers and evaluators this is valid expression:
XML = https://sparkle.musescore.org/stable/3/win/appcast.xml
XPATH = /rss/channel/item/enclosure/@sparkle:version

@chawyehsu chawyehsu mentioned this pull request May 15, 2019
Merged
@chawyehsu chawyehsu mentioned this pull request Jun 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ash258 Ash258 Ash258 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chawyehsu @Ash258 @r15ch13