Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(versions): Hotfix for #3333 #3578

Merged
merged 2 commits into from
Aug 2, 2019

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Aug 1, 2019

Hotfix for #3333

Fixed out of bounds error for updates like 1.0.0-beta4 -> 1.0.0, 1.16.0-rc2 -> 1.16.0, i.e., one is dashed version with alphabet while another is undashed version. (by L63-L70 in versions.ps1)

Also make alpha/beta/rc/prev versions lower than vanilla ones, see new test cases in Scoop-Versions.Tests.ps1.

@Ash258
Copy link
Contributor

Ash258 commented Aug 1, 2019

Nightly version comparison is also broken.

PS C:\WINDOWS\system32> scoop list docker                                                                               Installed apps matching 'docker':

  Docker nightly-20190621 [Ash258]

PS C:\WINDOWS\system32> scoop status                                                                                    Scoop is up to date.
Updates are available for:
    sudo: 0.2018.08.04 -> 0.2018.07.25
    vscode-insiders: nightly-20190726 -> nightly
    Docker: nightly-20190621 -> nightly

@niheaven
Copy link
Member Author

niheaven commented Aug 1, 2019

I'll check nightly error again, 'cos I haven't installed such ones...

@Ash258
Copy link
Contributor

Ash258 commented Aug 1, 2019

Best for debug will be visual studio code insiders, lightweight, only extraction and updated daily.

@niheaven
Copy link
Member Author

niheaven commented Aug 2, 2019

nightly version was treated as normal version and Compare-Version 'nightly' 'nightly-20190801' should return 1 which will not updated before...

Now nightly and nightly-xxx should be equal, and will not be updated.

@r15ch13 r15ch13 merged commit 3ca08a5 into ScoopInstaller:develop Aug 2, 2019
@niheaven niheaven deleted the fix-versions branch August 2, 2019 10:18
niheaven added a commit to niheaven/scoop that referenced this pull request Sep 18, 2019
r15ch13 pushed a commit that referenced this pull request Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants