Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Renovate): Correct some dependency types #342

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

Kurt-von-Laven
Copy link
Contributor

The npm manager considers Yarn v2+ to be of type packageManager rather than engines, so follow that convention for asdf and Yarn v1.

Introduce the new depType config for the centralized MegaLinter and Renovate configs as well as Yarn plugins. Use the commit scope config when bumping these dependencies. The centralized MegaLinter and Renovate configs are both governed by the same dependency, namely this repository itself, so using different types resulted in a duplicate row in the pull request descriptions generated by Renovate.

The npm manager considers Yarn v2+ to be of type `packageManager` rather
than `engines`, so follow that convention for asdf and Yarn v1.

Introduce the new `depType` `config` for the centralized MegaLinter and
Renovate configs as well as Yarn plugins. Use the commit scope `config`
when bumping these dependencies. The centralized MegaLinter and Renovate
configs are both governed by the same dependency, namely this repository
itself, so using different types resulted in a duplicate row in the pull
request descriptions generated by Renovate.
@Kurt-von-Laven Kurt-von-Laven self-assigned this Dec 5, 2023
Copy link
Contributor

@mwarres mwarres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kurt-von-Laven Kurt-von-Laven merged commit acc9da4 into main Dec 5, 2023
3 checks passed
@Kurt-von-Laven Kurt-von-Laven deleted the renovate branch December 5, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants