Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable required syn features #624

Merged
merged 1 commit into from
Mar 20, 2023
Merged

fix: enable required syn features #624

merged 1 commit into from
Mar 20, 2023

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Mar 20, 2023

PR Info

  • We need a PATCH release for this

Bug Fixes

  • Enabled required syn v1 features. Those features were enabled implicitly by other crates that depends on syn. Now, they have upgraded to syn v2 as a result those features of syn v1 is not enabled.

@ikrivosheev ikrivosheev merged commit b9c5438 into master Mar 20, 2023
@ikrivosheev ikrivosheev deleted the syn-features branch March 20, 2023 10:33
@ikrivosheev
Copy link
Member

@billy1624 thank you!

@ikrivosheev
Copy link
Member

@billy1624 I have cherry-picked your commit into https://github.com/SeaQL/sea-query/tree/0.28.x

@billy1624
Copy link
Member Author

Hey @ikrivosheev, sorry. I just double checked. The bug was introduced after 0.28.x. So, we don't need to backport the changes in this PR. Could you please revert the cherry-pick? Thanks!!

@ikrivosheev
Copy link
Member

@billy1624 done.

@github-actions
Copy link

🎉 Released In 0.29.0 🎉

Your participation is what makes us unique; your adoption is what drives us forward.
Thank you all in the Rust community for making SeaQL what it is today. 🦀
You are also invited to shape it's future! Please star our repos, every ⭐ counts!

@github-actions
Copy link

🎉 Released In 0.29.1 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants