Skip to content

Commit

Permalink
actually hide terminal until debug session (PowerShell#2437)
Browse files Browse the repository at this point in the history
  • Loading branch information
TylerLeonhardt committed Jan 27, 2020
1 parent 32c9623 commit a10ee7b
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 9 deletions.
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"publisher": "ms-vscode",
"description": "(Preview) Develop PowerShell scripts in Visual Studio Code!",
"engines": {
"vscode": "^1.34.0"
"vscode": "^1.40.0"
},
"license": "SEE LICENSE IN LICENSE.txt",
"homepage": "https://github.com/PowerShell/vscode-powershell/blob/master/README.md",
Expand Down Expand Up @@ -57,7 +57,7 @@
"@types/rewire": "~2.5.28",
"@types/semver": "~6.2.0",
"@types/sinon": "~7.5.1",
"@types/vscode": "1.34.0",
"@types/vscode": "1.40.0",
"mocha": "~5.2.0",
"mocha-junit-reporter": "~1.23.2",
"mocha-multi-reporters": "~1.1.7",
Expand Down
11 changes: 7 additions & 4 deletions src/process.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,15 @@ export class PowerShellProcess {

// Launch PowerShell in the integrated terminal
this.consoleTerminal =
vscode.window.createTerminal(
this.title,
this.exePath,
powerShellArgs);
vscode.window.createTerminal({
name: this.title,
shellPath: this.exePath,
shellArgs: powerShellArgs,
hideFromUser: !this.sessionSettings.integratedConsole.showOnStartup,
});

if (this.sessionSettings.integratedConsole.showOnStartup) {
// We still need to run this to set the active terminal to the Integrated Console.
this.consoleTerminal.show(true);
}

Expand Down

0 comments on commit a10ee7b

Please sign in to comment.