Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop/prepare-39 #17

Merged
merged 33 commits into from
Nov 3, 2020
Merged

develop/prepare-39 #17

merged 33 commits into from
Nov 3, 2020

Conversation

Segelzwerg
Copy link
Owner

Some mocking behavior is not working with <3.8

Marcel added 2 commits September 1, 2020 13:51
Some mocking behavior is not working with <3.8
@Segelzwerg
Copy link
Owner Author

Segelzwerg commented Sep 1, 2020

Codecov Report

Merging #17 into develop will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #17      +/-   ##
===========================================
- Coverage    98.47%   98.46%   -0.01%     
===========================================
  Files           18       18              
  Lines          458      457       -1     
===========================================
- Hits           451      450       -1     
  Misses           7        7              
Impacted Files Coverage Δ
family_foto/api/auth.py 96.96% <100.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8f7567...a06c404. Read the comment docs.

Marcel added 2 commits September 1, 2020 13:57
This is provisional until 3.9 is fully released.
@Segelzwerg
Copy link
Owner Author

Some and especially cffi is not ready.

see: https://pyreadiness.org/3.9/

@Segelzwerg
Copy link
Owner Author

Segelzwerg commented Oct 7, 2020

@hugovk
Copy link

hugovk commented Oct 14, 2020

Pillow 8.0.0 supporting Python 3.9 is now out!

@codecov-io
Copy link

codecov-io commented Oct 14, 2020

Codecov Report

Merging #17 into develop will decrease coverage by 2.23%.
The diff coverage is 88.78%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #17      +/-   ##
===========================================
- Coverage    98.47%   96.23%   -2.24%     
===========================================
  Files           18       19       +1     
  Lines          458      505      +47     
===========================================
+ Hits           451      486      +35     
- Misses           7       19      +12     
Impacted Files Coverage Δ
family_foto/models/video.py 76.00% <57.69%> (-20.88%) ⬇️
family_foto/web.py 99.09% <96.66%> (ø)
family_foto/api/auth.py 96.96% <100.00%> (-0.09%) ⬇️
family_foto/api/errors.py 100.00% <100.00%> (ø)
family_foto/const.py 100.00% <100.00%> (ø)
family_foto/forms/fields/multi_checkbox_field.py 100.00% <100.00%> (ø)
family_foto/forms/upload_form.py 100.00% <100.00%> (ø)
family_foto/models/file.py 100.00% <100.00%> (+1.78%) ⬆️
family_foto/models/photo.py 100.00% <100.00%> (ø)
family_foto/models/user.py 97.82% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8f7567...ad684c6. Read the comment docs.

@Segelzwerg
Copy link
Owner Author

Pillow 8.0.0 supporting Python 3.9 is now out!

yes, @hugovk thx for the info. We're still waiting for opencv-python who are waiting for numpy.

@hugovk
Copy link

hugovk commented Oct 17, 2020

NumPy is waiting on 3.9 for Windows on Azure Pipelines, due out early next week:

actions/runner-images#1740 (comment)

@Segelzwerg
Copy link
Owner Author

NumPy is waiting on 3.9 for Windows on Azure Pipelines, due out early next week:

actions/virtual-environments#1740 (comment)

Thx for the update. We currently in no need to rush it, although @iTitus did a lot of restructuring which we will release simultaneously.

@lgtm-com
Copy link

lgtm-com bot commented Nov 3, 2020

This pull request introduces 1 alert when merging 8e06f40 into f8f7567 - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

@Segelzwerg Segelzwerg merged commit efd0d0f into develop Nov 3, 2020
@Segelzwerg Segelzwerg deleted the develop-39python branch November 3, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants