Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using System for Trigger #7

Closed
wants to merge 2 commits into from
Closed

Using System for Trigger #7

wants to merge 2 commits into from

Conversation

hyranno
Copy link
Contributor

@hyranno hyranno commented Oct 8, 2023

Hello.
Bevy has its own mechanics to handle functions with SystemParam and corresponding SystemState.
This PR aim to

  • use it in TransitionImpl rather than implement
  • add interoperability for System and Trigger

The interoperability implemented as wrappers: TriggerSystemFunction and SystemFunctionTrigger.
I'm not so sure this is good implement.
I couldn't

  • implement IntoSystem on T: Trigger directly
  • implement without breaking change

Breaking Change

Trigger::trigger(&self, ...) -> Trigger::trigger(&mut self, ...)

@Seldom-SE
Copy link
Owner

Thanks for the pr, my life is busy right now, but I'll take a look when I'm able

@Seldom-SE
Copy link
Owner

I have some plans for an update (after 0.12 releases) that conceptually conflict with this, but I'll leave this open until I confirm that such plans are actually a good idea

@Seldom-SE
Copy link
Owner

Closing in favor of dec8a58

@Seldom-SE Seldom-SE closed this Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants