Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright Uniformity #401

Closed
ddavison opened this issue Apr 1, 2015 · 9 comments
Closed

Copyright Uniformity #401

ddavison opened this issue Apr 1, 2015 · 9 comments

Comments

@ddavison
Copy link
Member

ddavison commented Apr 1, 2015

Every other file has a different copyright heading. Everything from

Copyright 2007 - 2011 Software Freedom Conservancy

to

Copyright 2012 Selenium Committers

This issue should be dedicated to uniting all copyrights in each file. To do all of this, will be a time-consuming and daunting task, but should be done.

The issue could also be discussed as a forum for what the full-text of the copyright should be.

Consider it an Epic issue, and any PR's solely regarding documentation cleanup should be referred here.

In the future, expect PR's from me cleaning this up.

[I-cleanup?]

@ddavison
Copy link
Member Author

ddavison commented Apr 1, 2015

I remember talking about this in a previous pull request or issue, but i can't find it. the license for the project is obviously Apache v2, but who does the copyright go to? IIRC, it should really be:

Software Freedom Conservancy

@andreastt
Copy link
Member

We discussed this on IRC a few weeks back and CONTRIBUTING explains how copyright and attribution should work.

Every file should contain the follow header boilerplate, without year or copyright notice:

Licensed to the Software Freedom Conservancy (SFC) under one
or more contributor license agreements.  See the NOTICE file
distributed with this work for additional information
regarding copyright ownership.  The SFC licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License.  You may obtain a copy of the License at

  http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied.  See the License for the
specific language governing permissions and limitations
under the License.

The NOTICE file should contain the copyright assignment and year, and the LICENSE file should contain the Apache 2 license.

This follows the Apache Foundation's recommendations for licensing.

It's positively pointless busywork to update every file however. We can update each file as it's changed.

@ddavison ddavison mentioned this issue Apr 2, 2015
jleyba added a commit that referenced this issue Apr 4, 2015
I still need to update selenium-core - lots of files in there that need
manual review.
jleyba added a commit that referenced this issue Apr 5, 2015
Uses a line-comment format rather than block comments for consistency
across languages.
jleyba added a commit that referenced this issue Apr 5, 2015
…source code

    ./go copyright:update

This task ensures the copyright notice dictated in CONTRIBUTING.md is applied
at the top of every file and standardizes on a line-comment format.

The task currently covers the java/, py/, and javascript/ trees.

Close #405.
@andreastt
Copy link
Member

Closed by 6b4e6de.

@jleyba
Copy link
Contributor

jleyba commented Apr 5, 2015

Can't close yet. Still need rb/, cpp/, dotnet/ and a few others

@jleyba jleyba reopened this Apr 5, 2015
@andreastt
Copy link
Member

Oops, sorry about that!

@titusfortner
Copy link
Member

Want help doing the ruby ones? I can go through them today.

@andreastt
Copy link
Member

@titusfortner: If you can add an automated way to update the license headers for .rb files, please senda PR! See the commit that jleyba made for inspiration.

Please note that you must manually verify that every file you end up changing doesn't violate the file's existing license, e.g. if it's licensed under a different license or belongs to a different organisation than Software Freedom Conservancy.

@titusfortner
Copy link
Member

In the method requested, here's the pull request: #416

titusfortner added a commit to titusfortner/selenium that referenced this issue Apr 6, 2015
titusfortner added a commit to titusfortner/selenium that referenced this issue Apr 6, 2015
jimevans added a commit that referenced this issue Apr 13, 2015
Fixes copyright notices for files in the iedriver, iedriverserver,
and webdriver-server, in accordance with issue #401.
jimevans added a commit that referenced this issue Apr 13, 2015
Updates the copyright notices for all .NET non-test, non-Core projects,
in accordance with issue #401.
jimevans added a commit that referenced this issue Apr 13, 2015
Fixes copyright notices for files in the imehandler and
webdriver-interactions projects, in accordance with issue #401.
@ddavison
Copy link
Member Author

I believe we are all copacetic here so far. closing.

@lock lock bot locked and limited conversation to collaborators Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants