Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create temporary folder for Edge in IEMode #10006

Merged
merged 7 commits into from
Nov 3, 2021

Conversation

guangyuexu
Copy link
Contributor

Create temporary folder for Edge in IEMode

Description

This PR creates a unique temporary folder for Edge in IEMode. The temporary folder will be used as user data directory for the testing Edge browser. In addition, the temporary folder will be deleted when the test browser quits.

Motivation and Context

By creating a unique temporary folder, IEDriver can drive multiple Edge tests (in IEMode) without interfering each other.

Types of changes

  1. create a unique temporary folder
  2. use the temporary folder as user data directory for Edge in IEMode
  3. delete the temporary folder after browser quits

Copy link
Member

@jimevans jimevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly great work here. Mostly minor formatting and consistency issues here. Only one real thing requiring clarification.

cpp/iedriver/BrowserFactory.cpp Outdated Show resolved Hide resolved
cpp/iedriver/BrowserFactory.cpp Outdated Show resolved Hide resolved
cpp/iedriver/BrowserFactory.cpp Outdated Show resolved Hide resolved
cpp/iedriver/BrowserFactory.cpp Outdated Show resolved Hide resolved
cpp/iedriver/BrowserFactory.cpp Outdated Show resolved Hide resolved
cpp/iedriver/IECommandExecutor.cpp Outdated Show resolved Hide resolved
cpp/iedriver/BrowserFactory.cpp Outdated Show resolved Hide resolved
cpp/iedriver/BrowserFactory.h Outdated Show resolved Hide resolved
Copy link
Member

@jimevans jimevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will merge right away.

@jimevans jimevans merged commit a33e739 into SeleniumHQ:trunk Nov 3, 2021
@sonarcloud
Copy link

sonarcloud bot commented Nov 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants