-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Javascript] Split String on grapheme pairs in sendKeys command #10519
Conversation
Hi @gravityvi, Thanks for the PR. I tried passing With your changes I get the below error
|
Kudos, SonarCloud Quality Gate passed! |
JavaI tried the following code snippet in Java:
I see the same error as Harsha reported when using ChromeDriver:
However, it is a known ChromeDriver bug. I double-checked with FirefoxDriver and it works as expected. JavascriptI ran a similar test snippet in Javascript:
Before the changes in this PR:FirefoxDriver shows the error: ChromeDriver shows a vague error and stack trace. After the changes in this PR:FirefoxDriver works as expected with the emoji. ChromeDriver shows the error:
@harsha509 Hence, the error we encountered is not related to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @gravityvi !
…niumHQ#10519) * split string on grapheme pairs in sendKeys * added test for using emoji representated by pair of code points as sendKeys argument Co-authored-by: Diego Molina <diemol@users.noreply.github.com> Co-authored-by: Puja Jagani <puja.jagani93@gmail.com>
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
sendKeys
commandMotivation and Context
Types of changes
Checklist