[py] additional type hints in wait.py & command.py #10627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symonk
changed the title
symonk
commented
May 9, 2022
symonk
commented
May 9, 2022
AutomatedTester
approved these changes
May 23, 2022
Codecov Report
@@ Coverage Diff @@
## trunk #10627 +/- ##
==========================================
+ Coverage 45.48% 45.80% +0.32%
==========================================
Files 86 86
Lines 5712 5715 +3
Branches 277 280 +3
==========================================
+ Hits 2598 2618 +20
+ Misses 2837 2817 -20
- Partials 277 280 +3
Continue to review full report at Codecov.
|
|
Can you fix the tox stuff and then it's good to go |
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
* add additional types to `command.py` * [py]: adding some types to `wait.py` * [py]: add alias for wd wait types; ignore `*venv` for flake8 * [py]: Remove unused `InvalidSelectorException` import Co-authored-by: David Burns <david.burns@theautomatedtester.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor additional type hints for
command.py&wait.py. Need to figure out thedrivertype hint; but that'll be a decent win throughout once thats sorted in a follow up.