Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py]: Additional types for element fetching methods #10662

Merged
merged 4 commits into from
Jun 9, 2022

Conversation

symonk
Copy link
Member

@symonk symonk commented May 17, 2022

Add additional types in some places that fetch elements
removed unnecessary __ne__ implementation.

WebElement & ShadowRoot have a circular dependency, will address that one in future.

@codecov-commenter
Copy link

Codecov Report

Merging #10662 (3aa9573) into trunk (97aeedb) will increase coverage by 0.06%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##            trunk   #10662      +/-   ##
==========================================
+ Coverage   45.60%   45.67%   +0.06%     
==========================================
  Files          86       86              
  Lines        5741     5741              
  Branches      274      274              
==========================================
+ Hits         2618     2622       +4     
+ Misses       2849     2845       -4     
  Partials      274      274              
Impacted Files Coverage Δ
...lenium/webdriver/support/event_firing_webdriver.py 12.55% <20.00%> (+0.39%) ⬆️
py/selenium/webdriver/remote/webelement.py 30.11% <33.33%> (+0.65%) ⬆️
py/selenium/webdriver/remote/shadowroot.py 60.00% <100.00%> (+4.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97aeedb...3aa9573. Read the comment docs.

@titusfortner titusfortner added this to the 4.3 milestone May 24, 2022
@symonk symonk merged commit de9675b into SeleniumHQ:trunk Jun 9, 2022
@symonk symonk deleted the types-for-search-context-methods branch June 9, 2022 15:15
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
* add additional types for some `find_element?s(...)` methods

* [py]: fix unused imports in `event_firing_webdriver`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants