Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Add support for BiDi log event #10696

Merged
merged 6 commits into from
Jun 13, 2022
Merged

[java] Add support for BiDi log event #10696

merged 6 commits into from
Jun 13, 2022

Conversation

pujagani
Copy link
Contributor

Description

Add log.entryAdded support for BiDi. Related to #10335

Motivation and Context

BiDi supports log events to allow listening to different types of logs. The changes allow subscribing to such logs and mapping the result.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@diemol diemol merged commit a6359eb into SeleniumHQ:trunk Jun 13, 2022
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
@pujagani @elgatov
[java] Add support for BiDi log event (SeleniumHQ#10696)
0f1c94c 
* [java] Add support for BiDi log event

* [java] Disable BiDi log event tests temporarily

* [java] Update test to use the  logEntryAdded html page

* [java] No need to use Firefox beta for tests

Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
Co-authored-by: Diego Molina <diemol@gmail.com>

[skip ci]
@snyk-bot snyk-bot mentioned this pull request May 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diemol diemol diemol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pujagani @diemol