Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py]: remove redundant actions array of action_chains #10716

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

symonk
Copy link
Member

@symonk symonk commented May 31, 2022

remove the redundant _actions attribute of ActionChains, this is unused and just reassigned to an empty list.

@codecov-commenter
Copy link

Codecov Report

Merging #10716 (2ecbfe3) into trunk (f677d2d) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 2ecbfe3 differs from pull request most recent head 053b24c. Consider uploading reports for the commit 053b24c to get more accurate results

@@            Coverage Diff             @@
##            trunk   #10716      +/-   ##
==========================================
- Coverage   46.64%   46.64%   -0.01%     
==========================================
  Files          86       86              
  Lines        5855     5853       -2     
  Branches      278      277       -1     
==========================================
- Hits         2731     2730       -1     
  Misses       2846     2846              
+ Partials      278      277       -1     
Impacted Files Coverage Δ
py/selenium/webdriver/common/action_chains.py 32.00% <ø> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f677d2d...053b24c. Read the comment docs.

@symonk symonk merged commit be408c0 into SeleniumHQ:trunk Jun 9, 2022
@symonk symonk deleted the remove-redundant-actions-list branch June 9, 2022 10:48
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
…0716)

remove redundant actions array of `action_chains`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants