Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py]: Tweaks to select.py for pythonic naming and types #10756

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

symonk
Copy link
Member

@symonk symonk commented Jun 9, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #10756 (7ff463f) into trunk (7bd9b06) will increase coverage by 1.64%.
The diff coverage is 24.32%.

@@            Coverage Diff             @@
##            trunk   #10756      +/-   ##
==========================================
+ Coverage   46.56%   48.20%   +1.64%     
==========================================
  Files          86       86              
  Lines        5863     5570     -293     
  Branches      278      279       +1     
==========================================
- Hits         2730     2685      -45     
+ Misses       2855     2606     -249     
- Partials      278      279       +1     
Impacted Files Coverage Δ
py/selenium/webdriver/common/action_chains.py 32.00% <ø> (-0.29%) ⬇️
py/selenium/webdriver/remote/webelement.py 34.80% <ø> (+1.84%) ⬆️
...lenium/webdriver/support/event_firing_webdriver.py 18.85% <ø> (+8.30%) ⬆️
py/selenium/webdriver/support/select.py 25.42% <9.52%> (+17.22%) ⬆️
py/selenium/webdriver/remote/webdriver.py 38.98% <40.00%> (-2.92%) ⬇️
py/selenium/webdriver/remote/file_detector.py 100.00% <100.00%> (ø)
py/selenium/webdriver/remote/remote_connection.py 30.49% <0.00%> (-0.52%) ⬇️
py/selenium/types.py 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9018c6...7ff463f. Read the comment docs.

@symonk symonk merged commit 05467b6 into SeleniumHQ:trunk Jun 9, 2022
@symonk symonk deleted the pythonic-naming-in-select branch June 9, 2022 20:08
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants