Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Add BiDi augmenter #10789

Merged
merged 3 commits into from
Jun 22, 2022
Merged

Conversation

pujagani
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Add BiDi augmenter support

Motivation and Context

Add BiDi augmenter to allow RemoteWebDriver to use BiDi

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Merging #10789 (111854e) into trunk (385aaed) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            trunk   #10789   +/-   ##
=======================================
  Coverage   50.36%   50.36%           
=======================================
  Files          84       84           
  Lines        5490     5490           
  Branches      279      279           
=======================================
  Hits         2765     2765           
  Misses       2446     2446           
  Partials      279      279           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 385aaed...111854e. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pujagani pujagani merged commit 59ca70c into SeleniumHQ:trunk Jun 22, 2022
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants