[java] Allow linting only on the default test #10792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After migrating Selenium tests to JUnit 5, java_junit5_test delegates to contrib_rules_jvm’s java_test, and that adds lint tests for every target. We want to add one set of lint tests, since the rest are going to be identical. Therefore, we tag all but one test with no-lint
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
After migrating Selenium tests to JUnit 5, java_junit5_test delegates to contrib_rules_jvm’s java_test, and that adds lint tests for every target. We want to add one set of lint tests, since the rest are going to be identical. Therefore, we tag all but one test with no-lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After migrating Selenium tests to JUnit 5, the rule
java_junit5_testdelegates tocontrib_rules_jvm’sjava_test, and that adds lint tests for every target. We want to add one set of lint tests, since the rest are going to be identical. Therefore, we tag all but one test withno-lint.Motivation and Context
Improve the performance of spotbug tests (linting) after the migration to Selenium Java tests to JUnit 5 (issue #10196).
Types of changes
Checklist