Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Fix: making methods static #11182

Merged
merged 5 commits into from
Nov 1, 2022

Conversation

TamsilAmani
Copy link
Contributor

Description

This change is made (in JS) to be in line with the corresponding Java binding of Virtual Authenticator.

Motivation and Context

Please refer to methods

public static Credential createResidentCredential()
public static Credential createNonResidentCredential()

in https://github.com/SeleniumHQ/selenium/blob/trunk/java/src/org/openqa/selenium/virtualauthenticator/Credential.java

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@TamsilAmani
Copy link
Contributor Author

TamsilAmani commented Oct 31, 2022

After discussing with @pujagani and concluding that the initial changes were "breaking" in nature, I modified my code.

  1. This is NOT a breaking change now.
  2. Added static methods (with the same names as non-static ones) and kept the non-static methods as they are, but deprecated them.

Now the functions can be called either directly by class name or with class object. In future, we plan to delete the non-static ones after 3 releases (reason given in description).

Copy link
Contributor

@pujagani pujagani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TamsilAmani !

@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants