[js][BiDi] Browsing context commands #11473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pujagani
reviewed
Dec 23, 2022
|
LGTM from BiDi spec perspective. |
|
Can you do |
TamsilAmani
force-pushed
the
js-bidi-browsing-context
branch
from
f78d169
to
4c052b9
Compare
|
@harsha509 I ran |
harsha509
approved these changes
Dec 23, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add BrowsingContext module commands based on the spec.
Refer to BiDi spec doc for details.
Motivation and Context
Support BrowsingContext commands based on the W3C BiDi spec. Currently, the commands supported by browsers are made public. Refer https://wpt.fyi/results/webdriver/tests/bidi/browsing_context?label=experimental&label=master&aligned&view=subtest. As browsers implement the rest of the commands, we can make them public (adding methods will not be a breaking change).
Types of changes
Checklist