Making Python test webserver use host machines IP for testing instead of... #185
Conversation
… of localhost. This will allow for remote devices to be used in testing Updated all tests to use new method.
|
I should note I have a CLA signed for BlackBerry Ltd under rcraigbarnes@blackberry.com, this account just happens to be my github account. |
|
lgtm. But don't we need to add the Selenium header to the top of the new file? @AutomatedTester :) |
|
Is there anything that I need to do to move this along? I'd like to get this through so I can deal with the rest of the BlackBerry stuff that is coming :) |
|
The patch looks good to me. But I'm concerned about the legal side of including that new file. Maybe @AutomatedTester or @shs96c can say something about it. |
| @@ -0,0 +1,30 @@ | |||
| # this comes from this stack overflow post: | |||
There was a problem hiding this comment.
I have looked into this fully and we have met the original requirements for using this code on Web-platform-tests. StackOverflow code is cc-wiki + attribution for full programs but excerpts should just have attribution which all of StackOverflow falls under (see Jeff Atwoods thoughts on the matter.)
This means we should have a link to http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html here as well since its come from there. A link will satisfy the W3C licencing rules
|
Excellent. @glasspear, will you make it so? |
|
👍 no problem, these are all simple enough tweaks :) |
Updated network.py to include W3C copyright Added en0-en4 to interfaces to cover MacOS
|
Changes are in. Let me know if anything else is needed. |
|
merged with 4334d38 |
... localhost. This will allow for remote devices to be used in testing.
Updated all tests to use new method.