Fixed several typos in promise.js #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #3171 |
jleyba
reviewed
Nov 28, 2016
| @@ -2165,7 +2165,7 @@ const SIMPLE_SCHEDULER = new SimpleScheduler; | |||
| /** | |||
| * Handles the execution of scheduled tasks, each of which may be an | |||
| * asynchronous operation. The control flow will ensure tasks are executed in | |||
| * the ordered scheduled, starting each task only once those before it have | |||
| * the ordered schedule, starting each task only once those before it have | |||
|
Fixed, @jleyba please review |
|
Currently build in Travis failed because of "No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself." - see https://travis-ci.org/SeleniumHQ/selenium/jobs/179590026#L1780. So, it's definitely not because of the typos fixing in this PR. @jleyba please review again and merge if it's ok! |
|
@mach6 @lukeis @titusfortner please review |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement