Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js] fix docs typos #3295

Merged
merged 4 commits into from
Jan 7, 2017
Merged

[js] fix docs typos #3295

merged 4 commits into from
Jan 7, 2017

Conversation

Marketionist
Copy link
Contributor

@Marketionist
Copy link
Contributor Author

@mach6 @lukeis @titusfortner please review

@Marketionist
Copy link
Contributor Author

Currently build in Travis failed with:

assert 'bob' == ''

(https://travis-ci.org/SeleniumHQ/selenium/jobs/187081577#L1338)

and

expected no Exception, got #<Selenium::WebDriver::Error::TimeOutError: timed out after 5 seconds (Unable to locate element: #oneline

(https://travis-ci.org/SeleniumHQ/selenium/jobs/187081595#L870)

So, it's definitely not because of the typos fixing in this PR.

Copy link
Contributor

@cgoldberg cgoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove double spaces from the license header in capabilities.js when the same text appears in nearly every source file (with the double spaces)? seems like an arbitrary change making things inconsistent.

@Marketionist
Copy link
Contributor Author

I see your point @cgoldberg, agreed. Added back extra spaces in license for consistency. Please re-review and merge if ok

@cgoldberg
Copy link
Contributor

👍 I don't have access to merge though

@Marketionist
Copy link
Contributor Author

Thanks for reviewing!

@jleyba jleyba merged commit 482c91f into SeleniumHQ:master Jan 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants