Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] fix inverted logic and flake8 failure #3346

Merged
merged 1 commit into from
Jan 10, 2017

Conversation

lmtierney
Copy link
Member

The logic got inverted for determining if it the service has shutdown. It should break if not connectable. This was making each test take an additional 30 seconds (see Travis failures)

@lukeis lukeis merged commit dcc80b8 into SeleniumHQ:master Jan 10, 2017
@lukeis
Copy link
Member

lukeis commented Jan 10, 2017

thanks @lmtierney

@lmtierney lmtierney deleted the python-fix branch January 26, 2017 02:27
@lmtierney lmtierney restored the python-fix branch January 26, 2017 02:35
@lmtierney lmtierney deleted the python-fix branch January 26, 2017 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants