User agent for Python (and formerly Ruby, already merged) #5696
Conversation
|
Can you explain why you need these changes? |
|
Explanation is in the issue referenced in the description, but basically this is useful for error diagnosis in cloud services and grids. Similar changes have already been introduced for Java and .NET, so this is just rolling the feature out to more languages. |
|
Updated this PR to reflect just the Python change now that the Ruby change has been merged. |
sah
changed the title
sah
changed the title
| headers = { | ||
| 'Accept': 'application/json', | ||
| 'Content-Type': 'application/json;charset=UTF-8', | ||
| 'User-Agent': 'Python http auth' | ||
| 'User-Agent': 'selenium/%s (python %s)' % (__version__, system) |
There was a problem hiding this comment.
Prefer str.format for String Interpolation in the future
| @@ -33,7 +34,8 @@ def test_get_remote_connection_headers_defaults(): | |||
| assert 'Connection' not in headers.keys() | |||
| assert headers.get('Accept') == 'application/json' | |||
| assert headers.get('Content-Type') == 'application/json;charset=UTF-8' | |||
| assert headers.get('User-Agent') == 'Python http auth' | |||
| assert headers.get('User-Agent').startswith("selenium/%s (python " % __version__) | |||
| assert headers.get('User-Agent').split(' ')[-1] in {'windows)', 'mac)', 'linux)'} | |||
There was a problem hiding this comment.
Is there a reason you aren't just asserting the entire User-Agent? The second assertion could allow false positives if the wrong platform sent
There was a problem hiding this comment.
My reasoning was that asserting the whole thing requires duplicating the code to calculate the platform name, which proves nothing except that that code does whatever it does. This way if on OS X it returns "darwin" or on Windows it returns "win32", that issue will be caught when these tests are run on those platforms. I don't feel strongly about it though, happy to go a different route here if you prefer.
|
Merged, thanks! |
Addresses #5657 for Python and Ruby
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement