Refactor/ruby rake tasks tidy #7551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add author line
… down where appropriate
p0deje
reviewed
Sep 11, 2019
rake-tasks/ci.rb
Outdated
| body = infile.read | ||
| end | ||
|
|
||
| for i in 0..5 | ||
| (0..5).each do |_i| |
p0deje
reviewed
Sep 11, 2019
rake-tasks/ie_code_generator.rb
Outdated
| @@ -70,17 +74,17 @@ def generate_cpp_definitions(dest_file) | |||
|
|
|||
| def ie_generate_type_mapping(args) | |||
| types_mapping_file = args[:src] | |||
| generated_file = "#{args[:out]}" | |||
| generated_file = (args[:out]).to_s | |||
There was a problem hiding this comment.
I guess you can avoid wrapping in ().
|
Thanks @luke-hill ! |
jimevans
pushed a commit
to jimevans/selenium
that referenced
this pull request
Sep 13, 2019
* Autofixed 95% of the cop issues * Additional auto-fixes from rubocop * Final partial completed fixes of rubocop auto-correct * Undo YodaCondition in rake-tasks/checks.rb - Making further simplication easier * Fix up some string interpolation improvements and compress some lines down where appropriate * String interpolation fixes * CR: More tidy-up: Remove un-required syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xin the preceding checkbox, I verify that I have signed the Contributor License AgreementRefactor a load of ruby rake task code after chatting with Simon on IRC
Plan is to merge this then start simplifying the files afterwards