Refactor/rework ruby raketasks part1 #7562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r required / relevant
Massive tabbing fixes to crazy-fun/build_grammar.rb
|
The changes seem fine, but they don't work: https://travis-ci.com/SeleniumHQ/selenium/jobs/234810534#L513 |
|
Crap. Oki, give me a bit of time to dig in. I think I know where the issue is, but no idea why it's complaining. I may just revert that portion for ease of fix. |
|
Thank you, Luke! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xin the preceding checkbox, I verify that I have signed the Contributor License AgreementRework the rake-tasks folder by doing manual changes
Rework the
crazy-fun/build-tasks/build_grammar.rbby just fixing the tabs, and removing thethenkeyword after case statements. NB: There is a ginormous case statement around 300 lines in the middle, so I added a comment at the end. God help whoever has to refactor this!Review: @p0deje / @shs96c (Incase I've deleted / amended something as a breaking change)
I'd advise to review in 2 stages - One just for the crazy-fun one as it'll be awful to look at!