Added option to use char and string when generating atoms.cc #7784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous build structure allowed javascript atoms to be built with char_t and wstring or char and string. This restores that option, with char_t/wstring as the default. Adds utf8 parameter.
|
|
|
I don't believe the build failures are related to this change, the first references unresolveable dependencies on @platforms//os. The second is a classpath error while generating javadocs. Those definitions were not modified by this PR. |
|
Ah! Nice. Merging this now. Thank you for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7783
Add utf8 parameter for gen_file.py to enable creating atoms.cc and atoms.h with char* and std::string types. The default is True to preserve the prior behaviour, using char_t* and std::wstring.
ChromeDriver atoms BUILD was updated to set utf8 to False.
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement