[grid-ui] Changed BrowserRouter to HashRouter to allow pages to refresh. #8717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Updated BrowserRouter to HashRouter in App.tsx. The changes now refresh the GridUI pages without getting 404 error.
Motivation and Context
The first-time request is made to the GridUI via the server, it navigates to index.html. This is the default. Now any links clicked on the UI works fine, since it uses the react components and does not send a request to the server to load the UI components. When the page is refreshed it essentially sends the request to the server. If it is the root page, it works fine, since the server knows resource for it.
But if /console or /hub is refreshed, it errors out because the server is clueless. The HashRouter adds a hash to every link, example
http://localhost:4444/ui/index.html#/home
. The part after the hash before the hash is sent to the server which it knows, the part after is sent to react and it loads the page.Types of changes
Checklist