Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grid-ui] Changed BrowserRouter to HashRouter to allow pages to refresh. #8717

Merged
merged 3 commits into from
Sep 22, 2020

Conversation

pujagani
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Updated BrowserRouter to HashRouter in App.tsx. The changes now refresh the GridUI pages without getting 404 error.

Motivation and Context

The first-time request is made to the GridUI via the server, it navigates to index.html. This is the default. Now any links clicked on the UI works fine, since it uses the react components and does not send a request to the server to load the UI components. When the page is refreshed it essentially sends the request to the server. If it is the root page, it works fine, since the server knows resource for it.

But if /console or /hub is refreshed, it errors out because the server is clueless. The HashRouter adds a hash to every link, example http://localhost:4444/ui/index.html#/home. The part after the hash before the hash is sent to the server which it knows, the part after is sent to react and it loads the page.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@AutomatedTester AutomatedTester merged commit 3a60290 into SeleniumHQ:trunk Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants