Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing event logs with repetitive attributes that is covered by a different event log. #8773

Merged
merged 2 commits into from
Oct 14, 2020

Conversation

pujagani
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Cleaning up event logs to make it less noisy. The flow covered by the event logs is intact.

Motivation and Context

Earlier event logs were added to help with the debugging process leveraging the tracing framework. Some event logs had attributes that were repetitive. Removing these will help reduce the noisy logs.

  1. HandleSession events are reflected in SessionMap logs.
  2. All HTTP requests are wrapped in SpanWrappedHttpHandler. Which further delegated the request via client to be made to another server, so events in SpanWrappedHttpHandler should suffice rather than logging at delegate at the client as well.
  3. New session created details were logged at Distributor, LocalNode and DriverServiceSessionFactory. They all had the same information in the attributes. Hence, event log for the new session response was kept only in DriverServiceSessionFactory since it had the maximum context information,
  4. DockerSessionFactory log events updated to avoid repetitive container start logs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@AutomatedTester AutomatedTester merged commit 7ee0bac into SeleniumHQ:trunk Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants