[event-bus] Fix the double check for lazy initialisation of EventBus instance in EventBusOptions. #8817
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a local variable in the getEventBus() method of EventBusOptions to make lazy initialisation of EventBus thread-safe.
Motivation and Context
SonarLint pointed out a double-checking issue in EventBusOptions.
https://sonarcloud.io/component_measures?id=selenium&metric=reliability_rating&selected=selenium%3Ajava%2Fserver%2Fsrc%2Forg%2Fopenqa%2Fselenium%2Fgrid%2Fserver%2FEventBusOptions.java&view=list
In order to provide thread-safety, the issue is fixed by using a local variable inside the method and double-checking on it. The solution is per the suggestion from the Sonar linter.
Types of changes
Checklist