Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenTelemetry wrapper for the version 0.9.1 upgrade. #8835

Merged
merged 2 commits into from
Nov 4, 2020

Conversation

pujagani
Copy link
Contributor

@pujagani pujagani commented Nov 3, 2020

Description

Fix OpenTelemetry wrapper to accomodate 0.9.1 version bump.

Motivation and Context

Version bump for OpenTelemetry to 0.9.1 had many breaking changes as listed in :
https://github.com/open-telemetry/opentelemetry-java/blob/master/CHANGELOG.md

  • The changes made update OpenTelemetry wrapper APIs for trace id and span id.
  • Status is no longer supported. Hence, updated the wrapper to use StatusCanonicalCode.
  • Updated LoggingOptions to use Attributes for events and AttributesConsumer for correct json mapping for events and attributes.
  • Updating LoggingOptions to use OpenTelemetrySdk.getTracerManagement() to while getting a provider, since the current version returns an interface instead of provider implementation.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pujagani!

@diemol diemol merged commit c8f03a4 into SeleniumHQ:trunk Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants