[grid] Fix flaky Distributor and GraphqlHandlerTest. Add queuer config to DistributedCdpTest #8859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de to be added before creating session.
pujagani
added a commit
to pujagani/selenium
that referenced
this pull request
Nov 10, 2020
…g to DistributedCdpTest (SeleniumHQ#8859) * Add queuer config to DistributedCdpTest set up. * Add wait to DistributorTest and GraphqlHandlerTest to allow node to be added before creating session.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
The changes are related to failed tests reported in https://travis-ci.com/github/SeleniumHQ/selenium/jobs/431435876.
Motivation and Context
The failed build indicated flaky tests for GraphqlHandlerTest and DistributorTest. I suspect the issue was arising that session creation request was made before the grid model was updated by the distributor when a new node is added.
To fix it the test is made to wait until the distributor can handle sessions. Now session creation requests can be made and unit test assertions can proceed as expected.
Note: First tried the fix with 100 test runs in a branch before the NewSessionQueuer was introduced. After confirming issue is not due to the queuer changes, attempted the fix in the current Grid.
The DistributedCdp did not have queuer config and hence it was failing to create the Distributor. Fixed it by adding the queuer config.
Types of changes
Checklist