Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation for context propagation based on changed in OpenTelemetry 0.9.0. #8884

Merged

Conversation

pujagani
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

The changes add the required implementation for a propagating the tracing context correctly.

Motivation and Context

The version bump to 0.9.0 for OpenTelemertry made a breaking change of returning no-op TextMapPropagator. As a result, the trace context was not being passed when "inject" operation was called. So in a full distributed grid mode, a request had a different trace id and context as it made its way through different Grid 4 components instead of the same trace id. Thus, defeating the purpose of tracing.
The changes fix the above-mentioned issue by passing a valid implementation of TextMapPropagator. The changes add a unit test to safe-guard from future breaking changes in OpenTelemetry.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pujagani pujagani force-pushed the opentelemetry_context_propagation branch from e38d58e to 8a3e6af Compare November 18, 2020 11:25
@AutomatedTester AutomatedTester merged commit 64c6421 into SeleniumHQ:trunk Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants