Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP response span for grid status. Add tracing for GraphqlHandler. #8908

Merged
merged 2 commits into from
Nov 26, 2020

Conversation

pujagani
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Changes are related to #8883.

Motivation and Context

All incoming requests need to be a part of event-log. GridStatusHandler had a missing event-log. This change fixes that.
Graphql requests did not have tracing and the changes address that. As a result, now all incoming request are logged as event-logs with HTTP attributes.

Additionally, as a part of this, verified if event-logs are available for all path defined in SessionMap, Node, Distributor and Queuer.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@AutomatedTester AutomatedTester merged commit 2d5436c into SeleniumHQ:trunk Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants