[grid] Add lock while finding a node in GridModel setSession() method. Fix a log typo. #8980
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Adding a lock while finding a node in GridModel.
Motivation and Context
All methods using
findNode()
in GridModel grab a lock before calling it, exceptsetSession()
. LocalDistributor returns a Supplier on reserving a slot which calls setSession()selenium/java/server/src/org/openqa/selenium/grid/distributor/local/LocalDistributor.java
Line 383 in 5543c58
Since 'findNode()' loops over a HashSet(), in a multi-threaded environment this might cause errors. The changes add a lock in setSession().
Types of changes
Checklist