[JS] Add support for ChromeDriver --enable-chrome-logs
#9575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--enable-chrome-logs` ChromeDriver option can now be enabled using the Chromium (or Chrome) ServiceBuilder, similarly to the other options provided by ChromeDriver. I found this option critically useful for debugging test failures.
|
|
…chrome-logs-option
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
--enable-chrome-logsChromeDriver option can now be enabled using the Chromium (or Chrome) ServiceBuilder, similarly to the other options provided by ChromeDriver.Motivation and Context
I found this option critically useful for debugging test failures. It can reveal internal Chrome errors, or console errors for the page being tested.
Types of changes
Checklist
I have not added any additional tests because this module appears to be untested at the moment. I don't know enough about this project's test setup to know where to begin with that.