[py] PEP 484 type hints for selenium.webdriver.remote.file_detector #9606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
|
|
AutomatedTester
approved these changes
Jul 2, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
| from selenium.webdriver.common.utils import keys_to_typing | ||
| from selenium.types import AnyKey |
There was a problem hiding this comment.
just realised... This breaks things since there is not selenium types module, is there a PR for this?
There was a problem hiding this comment.
Oh, sorry @AutomatedTester , my bad. Let me take a look at this immediately - will add a PR this evening. Looks like I've forgotten to include a module in the previous commits! Sorry again.
There was a problem hiding this comment.
@AutomatedTester I have resolved this in #9647. Sorry again!
AutomatedTester
added a commit
that referenced
this pull request
Jul 12, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds type hints to
selenium.webdriver.remote.file_detector.Motivation and Context
This is a follow-up of #9482 to address #9480.
Types of changes
Checklist