Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataset/crop/feature/crop-all-within-polygon #71

Merged
merged 8 commits into from
Dec 28, 2023

Conversation

MAfarrag
Copy link
Member

@MAfarrag MAfarrag commented Dec 28, 2023

Crop cell that touches the mask not only lies inside.

Type of change

Check relevant points.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Please describe the tests that you ran to verify your changes.

  • Provide instructions so we can reproduce.

  • Please also list any relevant details for your test configuration

  • test_dataset::TestCropWithPolygon::test_inplace

  • test_dataset::TestCropWithPolygon::test_by_warp_touch_true

  • test_dataset::TestCropWithPolygon::test_by_warp_touch_false

  • test_dataset::TestStats::test_all_bands_with_mask

Checklist:

  • updated version number in setup.py/pyproject.toml.
  • updated environment.yml and the lock file.
  • added changes to History.rst.
  • updated the latest version in README file.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • documentation are updated.

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4725d7b) 83.29% compared to head (6580d6a) 83.75%.

Files Patch % Lines
pyramids/dataset.py 93.10% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   83.29%   83.75%   +0.46%     
==========================================
  Files           7        7              
  Lines        2119     2118       -1     
==========================================
+ Hits         1765     1774       +9     
+ Misses        354      344      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MAfarrag MAfarrag merged commit d645dd6 into main Dec 28, 2023
10 checks passed
@MAfarrag MAfarrag deleted the dataset/crop/feature/crop-all-within-polygon branch December 28, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant