[Header] Move 'Logo' to Global Theme settings (#2083)

Shopify · Dec 12, 2022 · 74b743c · 74b743c
1 parent bc6dd4c
commit 74b743c
Show file tree

Hide file tree

Showing 24 changed files with 595 additions and 489 deletions.
diff --git a/config/settings_schema.json b/config/settings_schema.json
@@ -7,6 +7,32 @@
     "theme_documentation_url": "https://help.shopify.com/manual/online-store/themes",
     "theme_support_url": "https://support.shopify.com/"
   },
+  {
+    "name": "t:settings_schema.logo.name",
+    "settings": [
+      {
+        "type": "image_picker",
+        "id": "logo",
+        "label": "t:settings_schema.logo.settings.logo_image.label"
+      },
+      {
+        "type": "range",
+        "id": "logo_width",
+        "min": 50,
+        "max": 300,
+        "step": 10,
+        "default": 100,
+        "unit": "px",
+        "label": "t:settings_schema.logo.settings.logo_width.label"
+      },
+      {
+        "type": "image_picker",
+        "id": "favicon",
+        "label": "t:settings_schema.logo.settings.favicon.label",
+        "info": "t:settings_schema.logo.settings.favicon.info"
+      }
+    ]
+  },
   {
     "name": "t:settings_schema.colors.name",
     "settings": [
@@ -1432,17 +1458,6 @@
       }
     ]
   },
-  {
-    "name": "t:settings_schema.favicon.name",
-    "settings": [
-      {
-        "type": "image_picker",
-        "id": "favicon",
-        "label": "t:settings_schema.favicon.settings.favicon.label",
-        "info": "t:settings_schema.favicon.settings.favicon.info"
-      }
-    ]
-  },
   {
     "name": "t:settings_schema.currency_format.name",
     "settings": [

diff --git a/locales/cs.schema.json b/locales/cs.schema.json
@@ -141,15 +141,6 @@
         "paragraph": "Košík a ceny na pokladně vždy zahrnují kódy měn. Příklad: 1,00 USD ($)"
       }
     },
-    "favicon": {
-      "name": "Favikona",
-      "settings": {
-        "favicon": {
-          "label": "Obrázek favikony",
-          "info": "Dojde ke zmenšení na 32 × 32 px"
-        }
-      }
-    },
     "layout": {
       "name": "Rozvržení",
       "settings": {
@@ -355,6 +346,22 @@
           "label": "Styl"
         }
       }
+    },
+    "logo": {
+      "name": "Logo",
+      "settings": {
+        "logo_image": {
+          "label": "Logo"
+        },
+        "logo_width": {
+          "label": "Šířka loga v počítači",
+          "info": "Šířka loga se automaticky optimalizuje pro mobilní prostředí."
+        },
+        "favicon": {
+          "label": "Obrázek favikony",
+          "info": "Dojde ke zmenšení na 32 × 32 px"
+        }
+      }
     }
   },
   "sections": {
@@ -810,13 +817,6 @@
     "header": {
       "name": "Záhlaví",
       "settings": {
-        "logo": {
-          "label": "Obrázek loga"
-        },
-        "logo_width": {
-          "unit": "px",
-          "label": "Šířka vlastního loga"
-        },
         "logo_position": {
           "label": "Pozice loga na počítači",
           "options__1": {
@@ -866,6 +866,12 @@
           "options__2": {
             "label": "Vlevo"
           }
+        },
+        "logo_header": {
+          "content": "Logo"
+        },
+        "logo_help": {
+          "content": "Logo upravíte v [nastavení motivu](/editor?context=theme&category=logo)."
         }
       }
     },
@@ -1460,12 +1466,11 @@
     "main-password-header": {
       "name": "Záhlaví hesla",
       "settings": {
-        "logo": {
-          "label": "Obrázek loga"
+        "logo_header": {
+          "content": "Logo"
         },
-        "logo_max_width": {
-          "label": "Šířka vlastního loga",
-          "unit": "px"
+        "logo_help": {
+          "content": "Logo upravíte v nastavení motivu."
         }
       }
     },

diff --git a/locales/da.schema.json b/locales/da.schema.json
@@ -141,15 +141,6 @@
         "paragraph": "Priser i indkøbskurv og betalingsproces viser altid valutakoder. Eksempel: 1,00 USD."
       }
     },
-    "favicon": {
-      "name": "Favoritikon",
-      "settings": {
-        "favicon": {
-          "label": "Billede for favoritikon",
-          "info": "Skaleres ned til 32 x 32 px"
-        }
-      }
-    },
     "layout": {
       "name": "Layout",
       "settings": {
@@ -355,6 +346,22 @@
           "label": "Stil"
         }
       }
+    },
+    "logo": {
+      "name": "Logo",
+      "settings": {
+        "logo_image": {
+          "label": "Logo"
+        },
+        "logo_width": {
+          "label": "Logobredde på computer",
+          "info": "Logobredden optimeres automatisk til mobiltelefoner."
+        },
+        "favicon": {
+          "label": "Billede for favoritikon",
+          "info": "Skaleres ned til 32 x 32 px"
+        }
+      }
     }
   },
   "sections": {
@@ -810,13 +817,6 @@
     "header": {
       "name": "Sidehoved",
       "settings": {
-        "logo": {
-          "label": "Logobillede"
-        },
-        "logo_width": {
-          "unit": "px",
-          "label": "Tilpasset logobredde"
-        },
         "logo_position": {
           "label": "Placering af logo på computer",
           "options__1": {
@@ -866,6 +866,12 @@
           "options__2": {
             "label": "Venstre"
           }
+        },
+        "logo_header": {
+          "content": "Logo"
+        },
+        "logo_help": {
+          "content": "Rediger dit logo i [temaindstillinger](/editor?context=theme&category=logo)."
         }
       }
     },
@@ -1460,12 +1466,11 @@
     "main-password-header": {
       "name": "Sidehoved på adgangskodesiden",
       "settings": {
-        "logo": {
-          "label": "Logobillede"
+        "logo_header": {
+          "content": "Logo"
         },
-        "logo_max_width": {
-          "label": "Tilpasset logobredde",
-          "unit": "px"
+        "logo_help": {
+          "content": "Rediger dit logo i temaindstillinger."
         }
       }
     },

diff --git a/locales/de.schema.json b/locales/de.schema.json
@@ -141,15 +141,6 @@
         "paragraph": "Warenkorb- und Checkout-Preise zeigen immer Währungscodes an. Beispiel: 1,00 USD."
       }
     },
-    "favicon": {
-      "name": "Favicon",
-      "settings": {
-        "favicon": {
-          "label": "Favicon-Bild",
-          "info": "Wird auf 32 x 32 Pixel verkleinert"
-        }
-      }
-    },
     "layout": {
       "name": "Layout",
       "settings": {
@@ -355,6 +346,22 @@
           "label": "Optik"
         }
       }
+    },
+    "logo": {
+      "name": "Logo",
+      "settings": {
+        "logo_image": {
+          "label": "Logo"
+        },
+        "logo_width": {
+          "label": "Desktop-Logobreite",
+          "info": "Die Logobreite wird automatisch für Mobilgeräte optimiert."
+        },
+        "favicon": {
+          "label": "Favicon-Bild",
+          "info": "Wird auf 32 x 32 Pixel verkleinert"
+        }
+      }
     }
   },
   "sections": {
@@ -810,13 +817,6 @@
     "header": {
       "name": "Header",
       "settings": {
-        "logo": {
-          "label": "Logo-Bild"
-        },
-        "logo_width": {
-          "unit": "Pixel",
-          "label": "Breite des benutzerdefinierten Logos"
-        },
         "logo_position": {
           "label": "Desktop-Logoposition",
           "options__1": {
@@ -866,6 +866,12 @@
           "options__2": {
             "label": "Links"
           }
+        },
+        "logo_header": {
+          "content": "Logo"
+        },
+        "logo_help": {
+          "content": "Bearbeite dein Logo in den [theme settings](/editor?context=theme&category=logo)."
         }
       }
     },
@@ -1460,12 +1466,11 @@
     "main-password-header": {
       "name": "Passwort-Header",
       "settings": {
-        "logo": {
-          "label": "Logo-Bild"
+        "logo_header": {
+          "content": "Logo"
         },
-        "logo_max_width": {
-          "label": "Breite des benutzerdefinierten Logos",
-          "unit": "Pixel"
+        "logo_help": {
+          "content": "Bearbeite dein Logo in den Theme-Einstellungen."
         }
       }
     },

diff --git a/locales/en.default.schema.json b/locales/en.default.schema.json
@@ -159,6 +159,22 @@
         }
       }
     },
+    "logo": {
+      "name": "Logo",
+      "settings": {
+        "logo_image": {
+          "label": "Logo"
+        },
+        "logo_width": {
+          "label": "Desktop logo width",
+          "info": "Logo width is automatically optimized for mobile."
+        },
+        "favicon": {
+          "label": "Favicon image",
+          "info": "Will be scaled down to 32 x 32px"
+        }
+      }
+    },
     "typography": {
       "name": "Typography",
       "settings": {
@@ -284,15 +300,6 @@
         }
       }
     },
-    "favicon": {
-      "name": "Favicon",
-      "settings": {
-        "favicon": {
-          "label": "Favicon image",
-          "info": "Will be scaled down to 32 x 32px"
-        }
-      }
-    },
     "currency_format": {
       "name": "Currency format",
       "settings": {
@@ -959,12 +966,11 @@
     "header": {
       "name": "Header",
       "settings": {
-        "logo": {
-          "label": "Logo image"
+        "logo_header": {
+          "content": "Logo"
         },
-        "logo_width": {
-          "unit": "px",
-          "label": "Custom logo width"
+        "logo_help": {
+          "content": "Edit your logo in [theme settings](/editor?context=theme&category=logo)."
         },
         "logo_position": {
           "label": "Desktop logo position",
@@ -1624,12 +1630,11 @@
     "main-password-header": {
       "name": "Password header",
       "settings": {
-        "logo": {
-          "label": "Logo image"
+        "logo_header": {
+          "content": "Logo"
         },
-        "logo_max_width": {
-          "label": "Custom logo width",
-          "unit": "px"
+        "logo_help": {
+          "content": "Edit your logo in theme settings."
         }
       }
     },