Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transform applied when it should not for sliders #2606

Merged
merged 1 commit into from
May 2, 2023

Conversation

ludoboludo
Copy link
Contributor

@ludoboludo ludoboludo commented May 2, 2023

PR Summary:

Making sure we're not moving the cards when they're in a slider

Why are these changes introduced?

This fixes a scenario in which animation are applied but cancelled on individual cards, while still applying a transform: translateY(2rem) on them. Which pushes them down and cut their shadow or content.

What approach did you take?

I added a transform: inherit to the existing CSS declaration preventing the slider card from animating.

Other considerations

Testing steps/scenarios

  • Toggle the animations applied to see and make sure that it doesn't impact the spacing on sliders.
  • Add some shadows vertically, on the cards and test sliders (blog posts, collection list, featured collection)
  • Test the 3D lift effect on cards as well to make sure it's not impacted

Demo links

Checklist

@LucasLacerdaUX LucasLacerdaUX self-requested a review May 2, 2023 19:31
Copy link
Contributor

@LucasLacerdaUX LucasLacerdaUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@eugenekasimov eugenekasimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ludoboludo ludoboludo merged commit 2e7d1bc into main May 2, 2023
@ludoboludo ludoboludo deleted the fix-spacing-for-animated-sliders branch May 2, 2023 20:23
jabrms pushed a commit to fp-trading/fp-trading-theme that referenced this pull request Jun 6, 2023
jabrms pushed a commit to fp-trading/fp-trading-theme that referenced this pull request Jun 12, 2023
pangloss added a commit to pangloss/dawn that referenced this pull request Jun 14, 2023
* shopify/main: (59 commits)
  [Announcement bar] Add social icons (Shopify#2497)
  Update theme version to match the pubic release (Shopify#2698)
  Add release/v10.0.0 branch fixes to main (Shopify#2693)
  fix default UI for dropdown and mega menu (Shopify#2644)
  Fix link formatting in Related Products heading (Shopify#2680)
  Update 2 translation files (Shopify#2637)
  Enable gift card recipient form by default on featured product section (Shopify#2666)
  Gift cards/enable recipient form by default (Shopify#2618)
  Add a Color Scheme setting for Menus-Header (Shopify#2622)
  Made mobile drawer full width by default-header (Shopify#2625)
  Allow multiple announcement bars in Header group (Shopify#2619)
  [Feat Product] Add rating styling sheet (Shopify#2620)
  Fix password page variables (Shopify#2607)
  Fix transform applied when it should not for sliders (Shopify#2606)
  Modify info string for gift card recipient checkbox (Shopify#2588)
  [3D lift animation] Raise hovered card above adjacent cards (Shopify#2589)
  Remove fallback color scheme info text (Shopify#2602)
  Fix CSS specifity issue to cancel animation for theme editor events (Shopify#2605)
  Remove settings daya for icon color (Shopify#2601)
  Follow ups for accessibility of announcements slider (Shopify#2580)
  ...
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants