Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Announcement Bar] Auto-rotate fixes #2810

Merged
merged 7 commits into from
Jul 11, 2023
Merged

[Announcement Bar] Auto-rotate fixes #2810

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4c47e1b
Update auto-rotate for the announcement bar
kjellr Jul 10, 2023
005da0a
Simplify the visibility rule.
kjellr Jul 10, 2023
8055019
Update 20 translation files
translation-platform[bot] Jul 10, 2023
57efe0c
Auto-advance to the selected message when block is selected.
kjellr Jul 10, 2023
be973a4
Merge branch 'main' into announcement-bar-auto-rotate-changes
kjellr Jul 10, 2023
4555211
Merge branch 'main' into announcement-bar-auto-rotate-changes
kjellr Jul 10, 2023
6f3df00
Merge branch 'main' into announcement-bar-auto-rotate-changes
kjellr Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Auto-advance to the selected message when block is selected.
  • Loading branch information
@kjellr
kjellr committed Jul 10, 2023
commit 57efe0c697b9161c209b1915dee7ad9b46cc5411
3 changes: 3 additions & 0 deletions sections/announcement-bar.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,9 @@
</button>
</div>
</slideshow-component>
{%- if request.design_mode -%}
<script src="{{ 'theme-editor.js' | asset_url }}" defer="defer"></script>
{%- endif -%}
{%- endif -%}
<div class="localization-wrapper">
{%- if section.settings.enable_country_selector and localization.available_countries.size > 1 -%}
Expand Down Expand Up @@ -205,7 +208,7 @@
</div>
</div>

{% schema %}

Check notice on line 211 in sections/announcement-bar.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/announcement-bar.liquid#L211 

[SchemaJsonFormat] JSON formatting could be improved
{
"name": "t:sections.announcement-bar.name",
"max_blocks": 12,
Expand Down
Loading