Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] QOL Cart race conditions #3395

Merged
merged 36 commits into from
May 6, 2024

Fix loader

e349ace
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

[Fix] QOL Cart race conditions #3395

Fix loader
e349ace
Select commit
Loading
Failed to load commit list.
GitHub Actions / Theme Check Report succeeded May 6, 2024 in 4s

Theme Check Report

0 error(s), 125 warning(s) found

Details

Configuration

Actions Input

Name Value
theme_root .
flags (not provided)
version (not provided)

ThemeCheck Configuration

---
root: "."
require: []
include_categories: []
exclude_categories: []
ignore:
- node_modules/*
extends: :nothing
ConvertIncludeToRender:
  enabled: true
  ignore: []
LiquidTag:
  enabled: true
  ignore: []
  min_consecutive_statements: 5
MissingTemplate:
  enabled: true
  ignore: []
  ignore_missing: []
NestedSnippet:
  enabled: true
  ignore: []
  max_nesting_level: 3
RequiredLayoutThemeObject:
  enabled: true
  ignore: []
SpaceInsideBraces:
  enabled: true
  ignore: []
SyntaxError:
  enabled: true
  ignore: []
TemplateLength:
  enabled: false
  ignore: []
  max_length: 600
  exclude_schema: true
  exclude_stylesheet: true
  exclude_javascript: true
UnknownFilter:
  enabled: true
  ignore: []
UnusedAssign:
  enabled: true
  ignore: []
UnusedSnippet:
  enabled: true
  ignore: []
MatchingSchemaTranslations:
  enabled: true
  ignore: []
MatchingTranslations:
  enabled: false
  ignore: []
DefaultLocale:
  enabled: true
  ignore: []
TranslationKeyExists:
  enabled: true
  ignore: []
ValidHTMLTranslation:
  enabled: true
  ignore: []
ValidJson:
  enabled: true
  ignore: []
ValidSchema:
  enabled: true
  ignore: []
MissingRequiredTemplateFiles:
  enabled: true
  ignore: []
UndefinedObject:
  enabled: true
  ignore: []
  exclude_snippets: true
  config_type: :default
RequiredDirectories:
  enabled: true
  ignore: []
DeprecatedFilter:
  enabled: true
  ignore: []
DeprecateLazysizes:
  enabled: true
  ignore: []
DeprecateBgsizes:
  enabled: true
  ignore: []
MissingEnableComment:
  enabled: true
  ignore: []
ParserBlockingJavaScript:
  enabled: true
  ignore: []
ParserBlockingScriptTag:
  enabled: true
  ignore: []
AssetPreload:
  enabled: true
  ignore: []
AssetSizeJavaScript:
  enabled: false
  threshold_in_bytes: 10000
  ignore: []
AssetSizeCSS:
  enabled: false
  threshold_in_bytes: 100000
  ignore: []
AssetSizeCSSStylesheetTag:
  enabled: false
  threshold_in_bytes: 100000
  ignore: []
ImgWidthAndHeight:
  enabled: true
  ignore: []
RemoteAsset:
  enabled: true
  ignore: []
AssetUrlFilters:
  enabled: true
  ignore: []
ContentForHeaderModification:
  enabled: true
  ignore: []
ImgLazyLoading:
  enabled: true
  ignore: []
HtmlParsingError:
  enabled: true
  ignore: []
AssetSizeAppBlockJavaScript:
  enabled: false
  ignore: []
  threshold_in_bytes: 10000
AssetSizeAppBlockCSS:
  enabled: false
  ignore: []
  threshold_in_bytes: 100000
AppBlockValidTags:
  enabled: false
  ignore: []
PaginationSize:
  enabled: true
  ignore: []
  min_size: 1
  max_size: 50
DeprecatedGlobalAppBlockType:
  enabled: true
SchemaJsonFormat:
  enabled: true
  start_level: 0
  indent: "  "

Annotations

Check warning on line 179 in layout/password.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

layout/password.liquid#L179

[AssetPreload] For better performance, prefer using the preload_tag filter

Check warning on line 184 in layout/password.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

layout/password.liquid#L184

[AssetPreload] For better performance, prefer using the preload_tag filter

Check warning on line 259 in layout/theme.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

layout/theme.liquid#L259

[AssetPreload] For better performance, prefer using the preload_tag filter

Check warning on line 264 in layout/theme.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

layout/theme.liquid#L264

[AssetPreload] For better performance, prefer using the preload_tag filter

Check notice on line 163 in sections/announcement-bar.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/announcement-bar.liquid#L163

[SchemaJsonFormat] JSON formatting could be improved

Check warning on line 101 in sections/collage.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/collage.liquid#L95-L101

[NestedSnippet] Too many nested snippets

Check warning on line 101 in sections/collage.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/collage.liquid#L95-L101

[NestedSnippet] Too many nested snippets

Check warning on line 101 in sections/collage.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/collage.liquid#L95-L101

[NestedSnippet] Too many nested snippets

Check warning on line 101 in sections/collage.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/collage.liquid#L95-L101

[NestedSnippet] Too many nested snippets

Check warning on line 101 in sections/collage.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/collage.liquid#L95-L101

[NestedSnippet] Too many nested snippets

Check warning on line 101 in sections/collage.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/collage.liquid#L95-L101

[NestedSnippet] Too many nested snippets

Check warning on line 101 in sections/collage.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/collage.liquid#L95-L101

[NestedSnippet] Too many nested snippets

Check warning on line 101 in sections/collage.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/collage.liquid#L95-L101

[NestedSnippet] Too many nested snippets

Check warning on line 101 in sections/collage.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/collage.liquid#L95-L101

[NestedSnippet] Too many nested snippets

Check warning on line 101 in sections/collage.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/collage.liquid#L95-L101

[NestedSnippet] Too many nested snippets

Check warning on line 101 in sections/collage.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/collage.liquid#L95-L101

[NestedSnippet] Too many nested snippets

Check warning on line 101 in sections/collage.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/collage.liquid#L95-L101

[NestedSnippet] Too many nested snippets

Check warning on line 101 in sections/collage.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/collage.liquid#L95-L101

[NestedSnippet] Too many nested snippets

Check warning on line 101 in sections/collage.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/collage.liquid#L95-L101

[NestedSnippet] Too many nested snippets

Check notice on line 211 in sections/collage.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/collage.liquid#L211

[SchemaJsonFormat] JSON formatting could be improved

Check notice on line 109 in sections/collapsible-content.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/collapsible-content.liquid#L109

[SchemaJsonFormat] JSON formatting could be improved

Check notice on line 132 in sections/collection-list.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/collection-list.liquid#L132

[SchemaJsonFormat] JSON formatting could be improved

Check notice on line 136 in sections/contact-form.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/contact-form.liquid#L136

[SchemaJsonFormat] JSON formatting could be improved

Check notice on line 139 in sections/email-signup-banner.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/email-signup-banner.liquid#L139

[SchemaJsonFormat] JSON formatting could be improved

Check notice on line 189 in sections/featured-blog.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/featured-blog.liquid#L189

[SchemaJsonFormat] JSON formatting could be improved