-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] QOL Cart race conditions #3395
Merged
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
5bb438c
Cart racing prototype
sofiamatulis c1037b7
Add promise
sofiamatulis 1a8c8ce
new approach
sofiamatulis 6c6c785
Refactor
sofiamatulis 64a2788
Fix multiple items
sofiamatulis 7f2aee0
Merge branch 'main' into cart-racing
sofiamatulis d6170be
Merge branch 'main' into cart-racing
sofiamatulis 3b0bc2b
Fix closing tag
sofiamatulis 29ae036
Clean up
sofiamatulis b900e52
Remove unused var
sofiamatulis e5f185b
Remove name
sofiamatulis b76ead6
Clean up ids
sofiamatulis 4e6fb73
Clean up func
sofiamatulis d208999
Clean up function
sofiamatulis 2f164c5
Check if remove all exists
sofiamatulis 9fc8728
Check if remove all exists
sofiamatulis e64ce07
Ensure it only updates when the user is done
sofiamatulis a835730
Remove unused promise
sofiamatulis 0954f4f
Update debouncer
sofiamatulis 1956e70
Fix typo
sofiamatulis 6471174
Create extendable comp
sofiamatulis 7e9500b
import js file
sofiamatulis b90f7a5
Feedback
sofiamatulis 8c119b1
feedback
sofiamatulis 9b482c8
Update settings json
sofiamatulis 16e1319
Revert
sofiamatulis 2623ff8
Fix trash behavior
sofiamatulis 1177dc1
Revert settings
sofiamatulis 1d99424
naming
sofiamatulis 88fe218
Ensure remove buton updates
sofiamatulis b51ef46
Fix spacing
sofiamatulis 4f353f7
Cleanup
sofiamatulis e8e7f86
Fix duplication
sofiamatulis d7b966c
Fix trash icon behavior;
sofiamatulis 0683db8
Fix logic
sofiamatulis e349ace
Fix loader
sofiamatulis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Cart racing prototype
- Loading branch information
commit 5bb438c4f158f2845d7a22112b19d10a0a3d66f3
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is commented out for now given that there is clamping happening + no errors returned from the BE. More info here: https://github.com/Shopify/shopify/issues/440605