Add subscription label to cart notification #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svinkle
approved these changes
Sep 24, 2021
| @@ -22,6 +22,9 @@ | |||
| {%- endfor -%} | |||
| </dl> | |||
| {%- endunless -%} | |||
| {%- if item.selling_plan_allocation != nil -%} | |||
There was a problem hiding this comment.
This is an extreme small nitpick, but I noticed on order.liquid we are using unless instead.
Should we keep it consistent?
{%- unless line_item.selling_plan_allocation == nil -%}
There was a problem hiding this comment.
Ohh, good question.
I'm pretty sure we previously agreed that we'd avoid using unless, except for very specific cases where the syntax becomes much clearer (unless cart.empty?) doing that way. I'm trying to find the GitHub thread where we discussed that back in February.
I'll keep this open until I find this (or confirm in our Slack channel).
There was a problem hiding this comment.
I believe you are right 🤔 in that case, we probably want to update the other file
sofiamatulis
approved these changes
Sep 28, 2021
Merged
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes introduced?
Fixes #673
What approach did you take?
Same approach used on
main-cart-items.liquid: output a<p>{{ item.selling_plan_allocation.selling_plan.name }}</p>element below the cart options.Demo links
Checklist