Product A11Y: Fix invalid HTML and announce price when updating variants #794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes introduced?
Accessibility fixes for Product page and Featured Product sections:
role="status"
to price container so the price is announced when variants are updatedFixes #126
Fixes #463
What approach did you take?
Followed suggestions on the issues.
To fix invalid HTML:
option.name
withoption.position
on the radio buttonid
s.option.name
can have spaces, resulting in a space separated (invalid)id
attribute.form
attributes to use the same{{ product_form_id }}
to keep consistency.disabled="true"
(invalid) todisabled="disabled"
(valid) in all JS files that are using this propertyTo announce price variants:
aria-hidden
from badges inprice.liquid
.role="status"
to the price region.Demo links
Suggested Tests
Accessibility
Functionality
Checklist